docs(design): FastMCP native registration investigation (#209)#250
Merged
docs(design): FastMCP native registration investigation (#209)#250
Conversation
Recommendation: stay with generation layer. FastMCP native path cannot produce the flat tool-arg surface AdCP requires without rebuilding the generation logic at registration time. Writeup documents the wire-shape mismatch, behavior that would need reimplementation, and re-open triggers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tool()with a pydantic-typed param nests args under the param name; AdCP needs request fields flat at the tool-argument level. No unwrap option in FastMCP.docs/design/mcp-native-registration.md— covers wire-shape mismatch, behavior that would need reimplementation (_inline_refs,additionalProperties: true, MRO-walk filtering, per-instance handler binding), startup-cost comparison, and re-open triggers.ADCP_TOOL_DEFINITIONS+_tool_to_requestinto one declarative table, and dropping unused hand-craftedinputSchemastubs.Closes #209.
Test plan
🤖 Generated with Claude Code